apply-tags: Tag multi-arch images as expected #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmeliik
reviewed
Sep 26, 2024
samdoran
force-pushed
the
apply-tags-multi-arch
branch
from
fc064c7
to
b30f340
Compare
When copying an image manifest, skopeo by default only copies the image matching the architecture of the system running skopeo. It does not copy the image manifest as expected. In my testing, adding the --multi-arch all flag on single architecture images works without error.
samdoran
force-pushed
the
apply-tags-multi-arch
branch
from
b30f340
to
2adf007
Compare
|
I fixed the CI failures. |
This will fail if any image referenced in the index doesn’t exist. That should be fine in this scenario since it is only expected to run this task on images that already exist.
|
/ok-to-test |
chmeliik
approved these changes
Sep 26, 2024
|
Thank you for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying an image manifest,
skopeoby default only copies the image matching the architecture of the system runningskopeo. It does not copy the image manifest as expected.In my testing, adding the
--multi-arch allflag on single architecture images works without error.