feat(STONEINTG-1078): Combine all FBC validation tasks into one #1534
+196,876
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arewm
force-pushed
the
fbc-pipeline-tech-debt
branch
from
a4ebd8d
to
64db07b
Compare
arewm
force-pushed
the
fbc-pipeline-tech-debt
branch
3 times, most recently
from
c278ac7
to
55ff684
Compare
arewm
force-pushed
the
fbc-pipeline-tech-debt
branch
from
55ff684
to
246ccc1
Compare
arewm
force-pushed
the
fbc-pipeline-tech-debt
branch
5 times, most recently
from
0cd30a4
to
01adb6b
Compare
|
@yashvardhannanavati @grokspawn , I cannot assign you as reviewers, but can you double check this PR? It is a big PR but the content should be largely unchanged from when it was separated into three tasks. |
arewm
changed the title
| approvers: | ||
| - integration-team | ||
| reviewers: | ||
| - integration-team |
There was a problem hiding this comment.
probably doesn't matter, but do you need a newline here?
This change combines the inspect-image, fbc-validate, and fbc-related-image-check into a single task. All of the old tasks will be deprecated and the required tasks need to be updated to require only ``` - [fbc-related-image-check, validate-fbc] ``` This will ensure that users can still be guaranteed to have a valid FBC fragment and appropriate related images. The following items were deferred from this task update: * make this task multi-arch aware. * make this task fail if a bundle is an image index reference * change the related-image check to be done in EC by exporting the set of related images Signed-off-by: arewm <[email protected]>
arewm
force-pushed
the
fbc-pipeline-tech-debt
branch
from
01adb6b
to
f3b2c7f
Compare
Just ran across the gh notification now. I'll take a look. I also couldn't assign me. 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change combines the inspect-image, fbc-validate, and fbc-related-image-check into a single task.
It depends on functionality that needs to be added to EC to parse the produced trusted artifact in order to assess whether the related images are valid.All of the old tasks will be deprecated and the required tasks need to be updated to require only
This will ensure that users can still be guaranteed to have a valid FBC fragment and appropriate related images.
EDIT: In order to merge this PR quicker, the functionality for moving the related image check was backed out. In a future PR, we can update the task to output the list of related images and have EC check them for validity.