feat: update createReleasePlan function #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinqi7
force-pushed
the
update_createReleasePlan
branch
2 times, most recently
from
10addd2
to
29827e7
Compare
jinqi7
changed the title
jinqi7
changed the title
jinqi7
force-pushed
the
update_createReleasePlan
branch
from
29827e7
to
95de1b4
Compare
mmalina
approved these changes
Oct 16, 2024
johnbieren
approved these changes
Oct 16, 2024
|
/approve |
jinqi7
force-pushed
the
update_createReleasePlan
branch
from
95de1b4
to
1934579
Compare
|
What is all this storeRelease stuff that was just added? Why is it part of the same PR? |
jinqi7
force-pushed
the
update_createReleasePlan
branch
from
1934579
to
22664af
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jinqi7, johnbieren, mmalina The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's something from another PR. Removed them. Thx |
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Signed-off-by: Jing Qi <[email protected]>
jinqi7
force-pushed
the
update_createReleasePlan
branch
from
22664af
to
2d863cd
Compare
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/lgtm |
This was referenced Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: