feat(ISV-5130): add Atlas secrets to e2e tests #1451
Conversation
|
Hi @jedinym. Thanks for your PR. I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Martin Jediny <[email protected]>
Signed-off-by: Martin Jediny <[email protected]>
Signed-off-by: Martin Jediny <[email protected]>
Signed-off-by: Martin Jediny <[email protected]>
Signed-off-by: Martin Jediny <[email protected]>
jedinym
changed the title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: johnbieren The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| // createSecretfromEnv creates a k8s Secret in the managed workspace if it | ||
| // doesn't exist. It populates the Secret data fields based on the mapping of | ||
| // fields to environment variables containing the base64 encoded field data. | ||
| func createSecretFromEnv( |
There was a problem hiding this comment.
Thanks for the contribution! This function can be added to releaseLib.go. The function name can be changed to something like "createOpaqueSecret" since it's to create a secret of Opaque type, manageFw can be changed to fw and managedNameSpace to namespace.
Signed-off-by: Martin Jediny <[email protected]>
Signed-off-by: Martin Jediny <[email protected]>
|
Looks good to me, will let Jing approve if it looks good to her as well |
Signed-off-by: Martin Jediny <[email protected]>
|
/ok-to-test |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ATLAS_STAGE_ACCOUNT_ENV string = "ATLAS_STAGE_ACCOUNT" | ||
|
|
||
| // SSO token for accessing the Atlas stage release instance | ||
| ATLAS_STAGE_TOKEN_ENV string = "ATLAS_STAGE_TOKEN" |
Check failure
Code scanning / Golang security checks by gosec
Potential hardcoded credentials Error
|
@johnbieren: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/e2e-tests:konflux-e2e-6hcj6 |
|
@johnbieren still waiting on @.shebert's manual action before the tests can work |
| Data: secretData, | ||
| } | ||
|
|
||
| _, err = fw.AsKubeAdmin.CommonController.CreateSecret( |
There was a problem hiding this comment.
There is some indent issue.
| secretData[field] = decodedValue | ||
| } | ||
|
|
||
| secret, err := fw.AsKubeAdmin.CommonController.GetSecret( |
| @@ -136,4 +140,44 @@ func CheckReleaseStatus(releaseCR *releaseApi.Release) (error) { | |||
| return nil | |||
| } | |||
|
|
|||
| // CreateOpaqueSecret creates a k8s Secret in the managed workspace if it | |||
There was a problem hiding this comment.
The managed workspace can be changed to workspace.
Description
In ISV-5130, the
rh-advisoriesandrh-push-to-registry-redhat-iopipelines gained the ability to upload component and product-level SBOMs to the Atlas release instance.The upload of SBOMs requires a new k8s Secret containing the SSO account and token for the stage Atlas release instance. The secret needs to be manually added by @.shebert or @.ralphbean.
This PR makes the e2e test use the new secrets and refactors secret creation to avoid duplicate code. I left the other tests use the old way of creating the secrets but I can refactor those as well if you wish.
Issue ticket number and link
ISV-5130 - Add new pipeline steps in rh-advisories for sbom upload
ISV-5394 - Update rh-advisories pipeline e2e tests
Type of change
Checklist: