Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RELEASE-951): integrate Checkton for linting #446

Merged

Conversation

seanconroy2021
Copy link
Member

@seanconroy2021 seanconroy2021 commented Jun 12, 2024

This updats the linting workflow by adding Checkton. Checkton will review code for linting errors.
Please see other PR here
Changes:

  • Added a step to the workflow to run Checkton for PR.
  • Configured Checkton to upload the SARIF report

Copy link

openshift-ci bot commented Jun 12, 2024

Hi @seanconroy2021. Thanks for your PR.

I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

johnbieren
johnbieren previously approved these changes Jul 5, 2024
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@seanconroy2021 seanconroy2021 changed the title WIP:feat(RELEASE-951): integrate Checkton for linting feat(RELEASE-951): integrate Checkton for linting Jul 8, 2024
@seanconroy2021 seanconroy2021 marked this pull request as ready for review July 8, 2024 07:54
@seanconroy2021 seanconroy2021 requested a review from a team as a code owner July 8, 2024 07:54
@openshift-ci openshift-ci bot removed the lgtm label Jul 8, 2024
johnbieren
johnbieren previously approved these changes Jul 8, 2024
@seanconroy2021 seanconroy2021 force-pushed the feat(951)-shellChecker branch 3 times, most recently from a27895d to cac841d Compare July 11, 2024 14:02
@openshift-ci openshift-ci bot added the lgtm label Jul 11, 2024
This updats the linting workflow by adding Checkton.
Checkton will review code for linting errors.

Changes:
* Added a step to the workflow to run Checkton.
* Configured Checkton to upload the SARIF report.

Signed-off-by: Sean Conroy <[email protected]>
Copy link

openshift-ci bot commented Jul 11, 2024

New changes are detected. LGTM label has been removed.

@seanconroy2021 seanconroy2021 merged commit 20e7d17 into konflux-ci:development Jul 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants