fix(RELEASE-1441): remove rsc from being managed

- the rsc needs to managed outside of the release
  service so that clusters can have a specific version
  for testing.
- A version can be deployed and managed by ArgoCD
  via infra-deployments for a specific cluster
- The controller will automatically persist an empty
  release service config if one is not present. This
  is needed for testing.

Signed-off-by: Scott Hebert <[email protected]>

config/manager/kustomization.yaml

@@ -1,7 +1,6 @@
 resources:
 - manager.yaml
 - network_policy.yaml
-- release_service_config.yaml
 
 generatorOptions:
   disableNameSuffixHash: true

config/rbac/kustomization.yaml

@@ -23,6 +23,9 @@ resources:
 - releaseplan_editor_role.yaml
 - releaseplan_role_binding.yaml
 - releaseplan_viewer_role.yaml
+- releaseserviceconfig_editor_role.yaml
+- releaseserviceconfig_role_binding.yaml
+- releaseserviceconfig_viewer_role.yaml
 - snapshotenvironmentbinding_editor_role.yaml
 - snapshotenvironmentbinding_role_binding.yaml
 - snapshot_editor_role.yaml

config/rbac/releaseserviceconfig_role_binding.yaml

@@ -0,0 +1,12 @@
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRoleBinding
+metadata:
+  name: releaseserviceconfig-role-binding
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: ClusterRole
+  name: releaseserviceconfig-editor-role
+subjects:
+  - kind: ServiceAccount
+    name: controller-manager
+    namespace: system

controllers/release/adapter.go

@@ -90,15 +90,24 @@ func (a *adapter) EnsureConfigIsLoaded() (controller.OperationResult, error) {
 	}
 
 	var err error
+	a.logger.Info("Getting Release Service Config")
 	a.releaseServiceConfig, err = a.loader.GetReleaseServiceConfig(a.ctx, a.client, v1alpha1.ReleaseServiceConfigResourceName, namespace)
 	if err != nil && !errors.IsNotFound(err) {
 		return controller.RequeueWithError(err)
 	}
 
 	if err != nil {
+		a.logger.Info("Creating Empty Release Service Config")
 		a.releaseServiceConfig = a.getEmptyReleaseServiceConfig(namespace)
+		patch := client.MergeFrom(a.releaseServiceConfig.DeepCopy())
+		err := a.client.Patch(a.ctx, a.releaseServiceConfig, patch)
+		if err != nil && !errors.IsNotFound(err) {
+			return controller.RequeueWithError(err)
+		}
+		a.logger.Info("Persisted Empty Release Service Config")
 	}
 
+	a.logger.Info("Release Service Config Loaded")
 	return controller.ContinueProcessing()
 }