fix(HACBS-2481): set readOnlyRootFilesystem for controller-manager #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugares
force-pushed
the
kube-lint-issues
branch
from
105705c to
9c2dc5b
Compare
scoheb
requested review from
a team,
theflockers,
davidmogar,
mmalina,
scoheb,
johnbieren,
kasemAlem and
happybhati
and removed request for
a team
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
=======================================
Coverage 85.21% 85.21%
=======================================
Files 23 23
Lines 1474 1474
=======================================
Hits 1256 1256
Misses 156 156
Partials 62 62 ☔ View full report in Codecov by Sentry. |
|
@davidmogar we should be good to merge this, right? |
This is addressing an issue reported by kube-linter. Signed-off-by: Hugo Ares <[email protected]>
hugares
force-pushed
the
kube-lint-issues
branch
from
9c2dc5b to
6a417cd
Compare
davidmogar
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing an issue reported by kube-linter, see [1] for rule description.
[1]https://github.com/stackrox/kube-linter/blob/main/docs/generated/checks.md#no-read-only-root-fs