feat: make use of the toolkit validator #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmogar
force-pushed
the
validator
branch
from
e941736 to
3bc9c11
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
- Coverage 85.21% 84.80% -0.41%
==========================================
Files 23 23
Lines 1474 1474
==========================================
- Hits 1256 1250 -6
- Misses 156 161 +5
- Partials 62 63 +1
☔ View full report in Codecov by Sentry. |
davidmogar
force-pushed
the
validator
branch
2 times, most recently
from
ee594f6 to
1039526
Compare
The Operator Toolkit validator allow us to define the validation functions and helps on testing the EnsureReleaseIsValid operation as now those validation functions can be mocked. Signed-off-by: David Moreno García <[email protected]>
davidmogar
force-pushed
the
validator
branch
from
1039526 to
b5117a8
Compare
johnbieren
approved these changes
Sep 1, 2023
|
/test release-service-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Operator Toolkit validator allow us to define the validation functions and helps on testing the EnsureReleaseIsValid operation as now those validation functions can be mocked.
Signed-off-by: David Moreno García [email protected]