refactor(HACBS-2550): pass git resolver info for verify-ec task #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbieren
requested review from
a team,
theflockers,
davidmogar,
mmalina,
scoheb,
kasemAlem,
happybhati and
Troy876
and removed request for
a team
|
Pairs with konflux-ci/e2e-tests#749 |
|
/test release-service-e2e |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
- Coverage 85.21% 85.20% -0.02%
==========================================
Files 23 23
Lines 1474 1473 -1
==========================================
- Hits 1256 1255 -1
Misses 156 156
Partials 62 62
☔ View full report in Codecov by Sentry. |
mmalina
reviewed
Sep 5, 2023
mmalina
reviewed
Sep 5, 2023
mmalina
reviewed
Sep 5, 2023
davidmogar
reviewed
Sep 5, 2023
johnbieren
force-pushed
the
hacbs_2550
branch
from
4ac63d1 to
f773678
Compare
kasemAlem
previously approved these changes
Sep 5, 2023
mmalina
previously approved these changes
Sep 5, 2023
The EnterpriseContact ConfigMap now contains the information needed for the git resolver of the proper task to use. This commit changes the adapter from passing the task bundle information to passing the task git resolver information. Signed-off-by: Johnny Bieren <[email protected]>
johnbieren
force-pushed
the
hacbs_2550
branch
from
f773678 to
e24dc02
Compare
davidmogar
approved these changes
Sep 5, 2023
johnbieren
added a commit
to johnbieren/release-service
that referenced
this pull request
Oct 23, 2023
This commit reverts konflux-ci#248 and has the operator pass a bundle ref for the verify-enterprise-contract task in the release pipelines once again. Signed-off-by: Johnny Bieren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EnterpriseContact ConfigMap now contains the information needed for the git resolver of the proper task to use. This commit changes the adapter from passing the task bundle information to passing the task git resolver information.