Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RELEASE-910): add timeout field to collectors #573

Merged
merged 1 commit into from
Sep 26, 2024
Merged

feat(RELEASE-910): add timeout field to collectors #573

merged 1 commit into from
Sep 26, 2024

Conversation

johnbieren
Copy link
Collaborator

@johnbieren johnbieren commented Sep 25, 2024 •
edited by openshift-ci bot
Loading

RELEASE-910 talks about passing a timeout with the collector, but no timeout field was included when they were added with RELEASE-908. This commit adds the timeout field.

@johnbieren
feat(RELEASE-910): add timeout field to collectors
dc401ae 
RELEASE-910 talks about passing a timeout with the collector, but no
timeout field was included when they were added with RELEASE-908. This
commit adds the timeout field.

Signed-off-by: Johnny Bieren <[email protected]>
@johnbieren johnbieren requested a review from a team as a code owner September 25, 2024 12:09
@openshift-ci openshift-ci bot added the lgtm label Sep 25, 2024
@johnbieren
Copy link
Collaborator Author

/retest

1 similar comment
@flacatus
Copy link

/retest

@johnbieren
Copy link
Collaborator Author

/test release-service-e2e

@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.97%. Comparing base (9d2ba52) to head (dc401ae).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
- Coverage   84.09%   83.97%   -0.13%     
==========================================
  Files          26       26              
  Lines        1635     1635              
==========================================
- Hits         1375     1373       -2     
- Misses        182      183       +1     
- Partials       78       79       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flacatus
Copy link

pipeline-service-in-cluster-local OutOfSync Degraded
Waiting 10 seconds for application sync
pipeline-service-in-cluster-local OutOfSync Degraded
Waiting 10 seconds for application sync
pipeline-service-in-cluster-local OutOfSync Degraded
Waiting 10 seconds for application sync
pipeline-service-in-cluster-local OutOfSync Degraded
Waiting 10 seconds for application sync

@flacatus
Copy link

/retest

5 similar comments
@johnbieren
Copy link
Collaborator Author

/retest

@jinqi7
Copy link
Contributor

jinqi7 commented Sep 26, 2024

/retest

@jinqi7
Copy link
Contributor

jinqi7 commented Sep 26, 2024

/retest

@jinqi7
Copy link
Contributor

jinqi7 commented Sep 26, 2024

/retest

@jinqi7
Copy link
Contributor

jinqi7 commented Sep 26, 2024

/retest

@johnbieren johnbieren merged commit 5d20d41 into konflux-ci:main Sep 26, 2024
13 checks passed
@johnbieren johnbieren deleted the release910 branch September 26, 2024 11:40
@johnbieren johnbieren mentioned this pull request Oct 14, 2024
Merged
@johnbieren johnbieren mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalina mmalina mmalina approved these changes

Assignees

@mmalina mmalina

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnbieren @flacatus @jinqi7 @mmalina