Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metrics still in wrong order #615

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

theflockers
Copy link
Collaborator

this PR fixes the order of metrics labels and values, and in addition modifies tests to use arbitrary strings intead of values from the label array, which was causing the test to not identify when the value was misplaced.

Copy link

openshift-ci bot commented Nov 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (3e48cb2) to head (91fa6f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #615   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files          26       26           
  Lines        2123     2123           
=======================================
  Hits         1749     1749           
  Misses        289      289           
  Partials       85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@theflockers theflockers force-pushed the fix_metrics_and_tests branch from 366432a to 91fa6f9 Compare November 22, 2024 15:56
@theflockers theflockers marked this pull request as ready for review November 22, 2024 17:34
@theflockers theflockers requested a review from a team as a code owner November 22, 2024 17:34
this PR fixes the order of metrics labels and values,
and in addition modifies tests to use arbitrary strings
intead of values from the label array, which was causing
the test to not identify when the value was misplaced.

Signed-off-by: Leandro Mendes <[email protected]>
@theflockers theflockers force-pushed the fix_metrics_and_tests branch from 91fa6f9 to b13a711 Compare November 25, 2024 17:54
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants