-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command line tool and support (plus split large files) #131
base: gh-pages
Are you sure you want to change the base?
Conversation
stub of command-line js-only version of index.html
translating to node
clean up filenames; print progress lines
Thank you so much for doing this, @danamlewis. I want to give this proper attention, and get it integrated into the repo (and into the website, at least referenced), though unfortunately am about to take off early in the morning for a couple weeks of travel. My apologies in advance for my delay in giving this the energy it deserves! |
Hi @konklone, I was talking with someone who's been using this on the command line and finding it helpful for their work, which reminded me to check in on this PR. I still think folks who find your web tool might find a command line version helpful, too, so please let me know if there's anything I can do in helping you review it (or likewise, understand if you'd prefer to close this/not incorporate, just let me know). Thanks again for the ongoing work on this type of tool! |
@danamlewis So, I'm really impressed with your work on complex-json2cv and jsonsplit here. I think the approach is a little inefficient and mixes some technical concerns, so let's see if we can talk through a way forward we both like. This PR adds a This has some downsides -- there's copied/pasted code that isn't used, there's HTML work being done that isn't relevant to command-line processing of JSON->CSV, and the Node module as published has a ton of stuff in it that isn't relevant to operation of the module. There's also a missed opportunity, I think, to integrate in the other direction -- have the Node module contain the core processing code, and then have the website JS call into the module JS, rather than having the module JS call into the website JS. The approach I think would work the best looks like this:
@danamlewis What do you think of the above? I can take a first pass at a new GitHub repo with the CLI/JS API core. |
Hey @konklone - thanks for the thoughtful review on this.
|
update dependencies in README
Created version as command line tool, including support for splitting large files.