update error messages for create

Makefile

@@ -4,7 +4,7 @@ SRC_DIR := ./
 BIN_NAME := lipo
 BINARY := bin/$(BIN_NAME)
 
-GOLANGCI_LINT_VERSION := v1.58.1
+GOLANGCI_LINT_VERSION := v1.62.2
 export GO111MODULE=on
 
 CMD_PACKAGE := github.com/konoui/lipo/cmd

go.mod

@@ -1,5 +1,5 @@
 module github.com/konoui/lipo
 
-go 1.22
+go 1.23
 
 require github.com/konoui/go-qsort v0.1.0

pkg/lipo/arch.go

@@ -106,6 +106,10 @@ func OpenArches(inputs []*ArchInput) ([]Arch, error) {
 		sr := io.NewSectionReader(f, 0, stats.Size())
 		obj, err := lmacho.NewArch(sr)
 		if err != nil {
+			fe := &lmacho.FormatError{}
+			if errors.As(err, &fe) {
+				return nil, fmt.Errorf("can't figure out the architecture type of: %s", input.Bin)
+			}
 			return nil, err
 		}
 

pkg/lipo/create_test.go

@@ -1,6 +1,7 @@
 package lipo_test
 
 import (
+	"os"
 	"path/filepath"
 	"strings"
 	"testing"
@@ -110,6 +111,34 @@ func TestLipo_CreateWithArch(t *testing.T) {
 	})
 }
 
+func TestLipo_CreateNonMachoFile(t *testing.T) {
+	tmp, err := os.CreateTemp(os.TempDir(), "dummy")
+	if err != nil {
+		t.Fatal(err.Error())
+	}
+	input := tmp.Name()
+	_, err = tmp.WriteString("dummydummy")
+	if err != nil {
+		t.Fatal(err)
+	}
+	tmp.Close()
+
+	l := lipo.New(
+		lipo.WithInputs(input),
+		lipo.WithOutput("dummy"),
+	)
+
+	err = l.Create()
+	if err == nil {
+		t.Fatal("an error does not occur")
+	}
+
+	want := "can't figure out the architecture type of:"
+	if !strings.Contains(err.Error(), want) {
+		t.Fatalf("want: %s, got: %s", want, err.Error())
+	}
+}
+
 func TestLipo_CreateError(t *testing.T) {
 	tests := []struct {
 		name       string
@@ -152,7 +181,7 @@ func TestLipo_CreateError(t *testing.T) {
 				lipo.WithSegAlign(tt.segAligns...))
 			err := l.Create()
 			if err == nil {
-				t.Fatal("error not occur")
+				t.Fatal("an error does not occur")
 			}
 			if !strings.Contains(err.Error(), tt.wantErrMsg) {
 				t.Fatalf("want: %s, got: %s", tt.wantErrMsg, err.Error())

pkg/lmacho/fat.go

@@ -177,6 +177,10 @@ func NewFatFile(ra io.ReaderAt) (*FatFile, error) {
 func NewArch(sr *io.SectionReader) (*Arch, error) {
 	mf, err := macho.NewFile(sr)
 	if err != nil {
+		fe := &macho.FormatError{}
+		if errors.As(err, &fe) {
+			return nil, &FormatError{Err: err}
+		}
 		return nil, err
 	}