[Feature/Helm] Add support --namespace helm arg #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdrix
approved these changes
Mar 15, 2022
cannonpalms
referenced
this pull request
in influxdata/nifikop
Mar 23, 2022
chore: merge with upstream
erdrix
pushed a commit
that referenced
this pull request
Aug 3, 2022
* Add support --namespace helm arg * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds support for
--namespacehelm argument to specify which ns to create objects in.Why?
When installing this chart, it would be nice to be able to specify
--namespace somensand have the objects put in the right namespace instead of always relying on the kube client being pointing at the correct ns.Additional context
Checklist