-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #7 add color, highlight extensions and fix text align buttons #19
Open
SalahAdDin
wants to merge
48
commits into
konstantinmuenster:main
Choose a base branch
from
SalahAdDin:feat/titap-plugins
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: #7 add color, highlight extensions and fix text align buttons #19
SalahAdDin
wants to merge
48
commits into
konstantinmuenster:main
from
SalahAdDin:feat/titap-plugins
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: adding scroll to editor content
chore: adding localization to the editor
feat: extension abbr
fix: dialogs in folder
feat: character and words count display
feat: adding Alert extension to the editor
fix: adding missing ", on es localization file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?It adds the Tiptap's color, highlight and text style extensions, their buttons, a color picker for the color, and the text align missing buttons.
Why is it needed?
Some content editors would want to highlight text and change its color.
Text Align extension is enabled but no buttons are handling it.
How to test it?
Write your content, select the text you want to modify, and change its alignment, color, or highlight it.
Kooha-2024-08-20-00-21-55.mp4
Notes
CustomElementRegistry.define: 'hex-color-picker' has already been defined as a custom element
. Please feel free to check it here.1.19.0
; we opened this thread on Discord and await answers.