Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #7 add color, highlight extensions and fix text align buttons #19

Open
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

SalahAdDin
Copy link

@SalahAdDin SalahAdDin commented Aug 20, 2024

What does it do?It adds the Tiptap's color, highlight and text style extensions, their buttons, a color picker for the color, and the text align missing buttons.

Why is it needed?

Some content editors would want to highlight text and change its color.

Text Align extension is enabled but no buttons are handling it.

How to test it?

Write your content, select the text you want to modify, and change its alignment, color, or highlight it.

Kooha-2024-08-20-00-21-55.mp4

Notes

  • It requires merging the following the PR above.
  • Sometimes we get the following error: CustomElementRegistry.define: 'hex-color-picker' has already been defined as a custom element. Please feel free to check it here.
  • There are styling issues related to Strapi Design System 1.19.0; we opened this thread on Discord and await answers.
  • We had to add color utils from this issue.

fix: adding scroll to editor content
chore: adding localization to the editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant