feat : custom repositories #2248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks good, but a couple of nits:
|
|
@jokestax can you fix the conflict before we review this please? |
|
I fixed it in the recent push |
|
We won't be able to merge this PR, you need to fix the conflict at the Git level.
|
|
@fharper, done (k3d isnt supported yet) |
|
@jokestax you wrote done, but it's a draft, just want to be sure it's ready for review? :) |
|
oh, should I wait for k3d support? |
|
Now it's supported :)
…On Thu, Jul 25, 2024, 00:13 Frédéric Harper ***@***.***> wrote:
oh, should I wait for k3d support?
—
Reply to this email directly, view it on GitHub
<#2248 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3442ZCDSNT6SFYT4ZA45NDZN7YUDAVCNFSM6AAAAABLCQKSEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYGY3TSNBYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Nice, undraft this PR when you are ready for us to review it :) |
|
its ready 👍 |
removed duplication signed commits return nil fix rebased changed sequence rebased vultr rebased vultr-1 resolve suggestions remove local dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can now deploy multiple repos on same organistation using below flags :
"--gitopsRepoName" metaphorRepoName "adminTeamName" "developerTeamName"
but we have to use kubefirst-api repo branch "feat-custom-repo" and kubefirst-gitops-template repo branch "feat-custom-repo" until its merged into main