Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reraise Excon errors as K8s::Errors #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kke
Copy link
Contributor

@kke kke commented Sep 4, 2019

Fixes #162

User should not care / know about transport backend.

  • Excon::Error::Certificate / Excon::Errors::CertificateError is raised as K8s::Error::SSL
  • Excon::Error::Socket / Excon::Errors::SocketError is raised as K8s::Error::Socket
  • Any unspecified (that were not already catched as K8s::Error::API, K8s::Error::HTTP_STATUS_ERRORS) Excon errors are reraised as K8s::Error::Transport.
  • rescuing K8s::Error::Transport will also rescue from ::SSL and ::Socket as they are inherited from ::Transport.

@kke kke added bug Something isn't working enhancement New feature or request chore labels Sep 4, 2019
@kke kke added this to the 1.0.0 milestone Sep 4, 2019
@kke kke self-assigned this Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excon errors should not be leaked upwards
1 participant