Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change the folder patch operation type into a discriminated union #142

Merged
merged 19 commits into from
Mar 1, 2024
Merged

feat: change the folder patch operation type into a discriminated union #142

merged 19 commits into from
Mar 1, 2024

Conversation

Nickm615
Copy link
Collaborator

Motivation

Which issue does this fix? Fixes #138

Checklist

  • [ x] Code follows coding conventions held in this repo
  • [ x] Automated tests have been added
  • [ x] Tests are passing
  • [ x] Docs have been updated (if applicable)
  • [ x] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

Manual testing not required

Nickm615 added 18 commits January 31, 2024 10:11
@Nickm615
added display_timezone to workflow model
e35acbf
@Nickm615
added IListLanguageVariantsBySpaceResponseContract
9cea528
@Nickm615
added ListLanguageVariantsByCollectionResponse
1cfe53c
@Nickm615
added listLanguageVariantsBySpaceAsync to query service
5102496
@Nickm615
added mapLanguageVariantsByCollectionResponse to mapper
6b08a2e
@Nickm615
added listLanguageVariantsBySpace to api-endpoints. Added list-langua…
260541e 
…ge-variants-by-space to language variant queries. Added ListAllLanguageVariantsBySpaceResponse to language variant responses
@Nickm615
added fake-list-language-variants-by-space
a3c36e0
@Nickm615
added list-language-variants-by-space.spec
978d5c2
@Nickm615
added listLanguageVariantsByCollection() to imanagement-client.interf…
0e0cf84 
…ace.ts
@Nickm615
local tests successful, final changes
652280b
@Nickm615
updated space.models.ts with collections property
d6d183f
@Nickm615
updated space-contract.ts with collections property
b65161f
@Nickm615
updated space fake responses with collections property
9e74ec4
@Nickm615
updated space tests to validate collections property
d948ef7
@Nickm615
added collection property to mapSpace, updated test cases. All tests …
b36ebaf 
…passing
@Nickm615
added IModifyAssetFolderOperations and operation types to asset-folde…
fa565a0 
…r.models.ts
@Nickm615
changed IAddOrModifyAssetFolderData to IAssetFolderData updated manag…
309238a 
…ment-client.class.ts to reflect new types
@Nickm615
updated references in client, query and service. Tests passing
c31bf35
@Nickm615 Nickm615 requested review from IvanKiral, Enngage and a team as code owners February 29, 2024 16:30
@Enngage Enngage changed the title Change the folder patch operation type into a discriminated union feat: change the folder patch operation type into a discriminated union Mar 1, 2024
@Enngage Enngage merged commit 6994c3a into kontent-ai:master Mar 1, 2024
1 check passed
@Enngage Enngage mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanKiral IvanKiral Awaiting requested review from IvanKiral IvanKiral is a code owner

@Enngage Enngage Awaiting requested review from Enngage Enngage is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the folder patch operation type into a discriminated union
2 participants
@Nickm615 @Enngage