Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes wrong webhook filter types #149

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

pokornyd
Copy link
Member

@pokornyd pokornyd commented May 7, 2024

Motivation

Fixes #148

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@pokornyd
Copy link
Member Author

pokornyd commented May 7, 2024

setting as draft, since some adjustments to tests might be in order, to ensure correct property mapping

@Enngage Enngage changed the title fix wrong webhook filter types fix: Fixes wrong webhook filter types May 7, 2024
@Enngage Enngage marked this pull request as ready for review May 7, 2024 09:38
@Enngage Enngage requested review from IvanKiral, Enngage and a team as code owners May 7, 2024 09:38
@Enngage Enngage merged commit 8a491cb into master May 7, 2024
1 check passed
@Enngage Enngage deleted the 148-webhook-filters branch May 7, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook filter types not aligned with API
2 participants