Махлонов Дмитрий #207
Open
Махлонов Дмитрий #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlazProject
suggested changes
Dec 8, 2024
...Printing/Tests/Cases/ObjectPrinterTests.ObjectPrinter_ProcessesRecursionCorrect.received.txt
Outdated
Show resolved
Hide resolved
GlazProject
reviewed
Dec 12, 2024
| private const int MAX_RECURSION = 1; | ||
| private int currentRecursion = 0; | ||
| internal readonly SerializeConfig<TOwner> config = new(); | ||
| private HashSet<object> processedObjects = new(ReferenceEqualityComparer.Instance); |
| return "null" + Environment.NewLine; | ||
|
|
||
| if (name != null && config.PropertySerializers.TryGetValue(name, out var serializer)) | ||
| return serializer.DynamicInvoke(obj).ToString() + Environment.NewLine; | ||
| if (processedObjects.Contains(obj)) |
There was a problem hiding this comment.
Не стоит выбрасывать логику currentRecursion++ > MAX_RECURSION, так как рисовать 1000 вложенных объектов - всё равно не очень хорошо
| result = null; | ||
| if (name != null && Config.PropertySerializers.TryGetValue(name, out var serializer)) | ||
| { | ||
| result = serializer.Invoke(obj) + Environment.NewLine; |
There was a problem hiding this comment.
Функции можно вызывать просто об скобок serializer(obj). Чуть проще становится читать код
| private bool TryPrintFinalTypes(Type? type, string? name, object obj, out string? result) | ||
| { | ||
| result = null; | ||
| var finalTypes = new List<Type> |
| return sb.ToString(); | ||
| } | ||
|
|
||
| private string PrintIDictionary(IDictionary obj, int nestingLevel) |
There was a problem hiding this comment.
Если брать простые значения, то получается не очень понятная структура. Но это больше просто на подумать, такое решение вполне жизнеспособно
Key: youTube
Value: 3
Key: fabric
Value: 15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.