Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Козлов Данил #213

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Козлов Данил #213

wants to merge 13 commits into from

Conversation

SenyaPevko
Copy link

dmnovikova
dmnovikova reviewed Dec 5, 2023
View reviewed changes
...dVisualization/TagsCloudVisualization/TagsCloudVisualization/Interfaces/IRectanglesPlacer.cs Outdated Show resolved Hide resolved
...loudVisualization/TagsCloudVisualization/TagsCloudVisualization/Interfaces/ICloudLayouter.cs Show resolved Hide resolved
cs/TagsCloudVisualization/TagsCloudVisualization/TagsCloudVisualization/Utils/Utils.cs Outdated Show resolved Hide resolved
cs/TagsCloudVisualization/TagsCloudVisualization/TagsCloudVisualization/Utils/Utils.cs Outdated Show resolved Hide resolved
cs/TagsCloudVisualization/TagsCloudVisualization/TagsCloudVisualization/Utils/Utils.cs Outdated Show resolved Hide resolved
cs/TagsCloudVisualization/TagsCloudVisualization/Tests/CircularCloudLayouterTests.cs Outdated Show resolved Hide resolved
cs/TagsCloudVisualization/TagsCloudVisualization/Tests/CloudLayoutDrawerTests.cs Outdated Show resolved Hide resolved
cs/TagsCloudVisualization/TagsCloudVisualization/Tests/CloudLayoutDrawerTests.cs Outdated Show resolved Hide resolved
cs/TagsCloudVisualization/TagsCloudVisualization/Tests/Tests.csproj Outdated Show resolved Hide resolved
cs/TagsCloudVisualization/TagsCloudVisualization/Tests/CircularCloudLayouterTests.cs Outdated Show resolved Hide resolved
@dmnovikova
Copy link

dmnovikova commented Dec 11, 2023 •
edited
Loading

Зачем ты удалил Tests.scproj? Теперь не подгружается проект тестов целиком
В файлах .csproj конфиг проекта, информация о файлах, содержащихся в нем, ссылки на сборки и тд

Если ты хотел удалить из проекта FailedTestsLayouts, то нужно было убрать из файла Tests.scproj строки

  <ItemGroup>
    <Folder Include="FailedTestsLayouts\" />
  </ItemGroup>

чтобы посмотреть содержимое Tests.scproj, нужно курсором встать на проект + F4

Если удалять FailedTestsLayouts из среды разработки, то нужные ссылки в Tests.scproj автоматически удалятся
Тут, видимо, файл удалялся руками в папке

dmnovikova
dmnovikova reviewed Dec 11, 2023
View reviewed changes
cs/TagsCloudVisualization/TagsCloudVisualization/TagsCloudVisualization/CloudDrawer.cs Outdated
return bitmap;
}

public static float CalculateObjectDrawingScale(float width, float heigth, float imageWidth, float imageHeight)
Copy link

@dmnovikova dmnovikova Dec 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private
описка в heigth — исправлено

cs/TagsCloudVisualization/TagsCloudVisualization/TagsCloudVisualization/CloudDrawer.cs Outdated Show resolved Hide resolved
@dmnovikova
Copy link

Странно, что решарпер требует землю в начале именования приватных полей :/
Их можно было оставить как есть

@dmnovikova
Copy link

Зачтено ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmnovikova dmnovikova dmnovikova left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SenyaPevko @dmnovikova