Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Andronov Alexander #224

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Andronov Alexander #224

wants to merge 6 commits into from

Conversation

batyadmx
Copy link

@batyadmx batyadmx commented Dec 5, 2023

elizShtol
elizShtol reviewed Dec 6, 2023
View reviewed changes
cs/TagCloud.Tests/CircularCloudLayouterTests.cs Outdated
[OneTimeSetUp]
public void OneTimeSetup()
{
var path = Path.Combine(projectDirectory, "FailureImages");

This comment was marked as resolved.

Sign in to view

cs/TagCloud.Tests/CircularCloudLayouterTests.cs Outdated
}
}

private void GenerateSizes()

This comment was marked as resolved.

Sign in to view

cs/TagCloud.Tests/CircularCloudLayouterTests.cs Outdated
Comment on lines 61 to 62
if (rect1.IntersectsWith(rect2))
Assert.False(rect1.IntersectsWith(rect2));

This comment was marked as resolved.

Sign in to view

cs/TagCloud.Tests/CircularCloudLayouterTests.cs Outdated
{
var rect = layouter.PutNextRectangle(sizes[0]);

Assert.True(rect.Width == sizes[0].Width && rect.Height == sizes[0].Height);

This comment was marked as resolved.

Sign in to view

cs/TagCloud.Tests/CircularCloudLayouterTests.cs Outdated
{
public class CircularCloudLayouterTests
{
private readonly string projectDirectory

This comment was marked as resolved.

Sign in to view

cs/TagCloud.Tests/CircularCloudLayouterTests.cs

namespace TagCloud.Tests
{
public class CircularCloudLayouterTests

This comment was marked as resolved.

Sign in to view

cs/TagCloud/CircularCloudLayouter.cs

namespace TagCloud
{
public class CircularCloudLayouter : ITagCloudLayouter

This comment was marked as resolved.

Sign in to view

elizShtol
elizShtol reviewed Dec 9, 2023
View reviewed changes
cs/TagCloud/MathHelpers.cs Outdated

namespace TagCloud
{
public static class MathHelpers

This comment was marked as resolved.

Sign in to view

cs/TagCloud/CircularCloudLayouter.cs Outdated
Comment on lines 55 to 56
movedDx = dx == 0 ? false : OffsetIfDontCollide(ref rect, dx, 0);
movedDy = dy == 0 ? false : OffsetIfDontCollide(ref rect, 0, dy);

This comment was marked as resolved.

Sign in to view

cs/TagCloud/CircularCloudLayouter.cs

private void UpdateDirections()
{
var directions = new List<Vector2>();

This comment was marked as resolved.

Sign in to view

cs/TagCloud/CircularCloudLayouter.cs Outdated
{
private int i;
private List<RectangleF> rectangles = new List<RectangleF>();
private PointF center;

This comment was marked as resolved.

Sign in to view

cs/TagCloud/CircularCloudLayouter.cs Outdated
private PointF center;
private RectangleF currentRectangle;
private int segmentsCount = 2;
private List<Vector2> directions;

This comment was marked as resolved.

Sign in to view

elizShtol
elizShtol reviewed Dec 11, 2023
View reviewed changes
cs/TagCloud.Tests/CircularCloudLayouterTests.cs Outdated
}

[Test]
public void PutNextRectangle_PlaceManyRectangles_ShouldFitInCircleAroundCenter()

This comment was marked as resolved.

Sign in to view

elizShtol
elizShtol reviewed Dec 11, 2023
View reviewed changes
cs/TagCloud/TagCloudForDebug.cs Outdated

namespace TagCloud
{
public class TagCloudForDebug

This comment was marked as resolved.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizShtol elizShtol elizShtol left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@batyadmx @elizShtol