Sibogatov Rinat #244
Open
Sibogatov Rinat #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69raccoon96
suggested changes
Nov 29, 2023
cs/HomeExercises/ObjectComparison.cs
Outdated
| @@ -14,17 +14,10 @@ public void CheckCurrentTsar() | |||
|
|
|||
| var expectedTsar = new Person("Ivan IV The Terrible", 54, 170, 70, | |||
| new Person("Vasili III of Russia", 28, 170, 60, null)); | |||
|
|
|||
| actualTsar.Should().BeEquivalentTo(expectedTsar, options => options | |||
| .Excluding(member => member.SelectedMemberInfo.Name.ToLower().Contains("id"))); | |||
There was a problem hiding this comment.
Не очень хороший вариант, а если добавятся еще какие-то поля, в названии которых будет Id, но их не нужно будет исключать? Поэтому тут я бы предложил просто использовать ==
| public void isValidNumber_ShouldBeTrue_WhenNumberWithSigns(string number, bool result) | ||
| { | ||
| var validator = new NumberValidator(7, 3, true); | ||
| validator.IsValidNumber(number).Should().Be(result); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Вынести в отдельный файл класс ниже, почему-то не могу к нему коммент оставить. На шпоре, имхо, важно не только смотреть на то место, куда ты вносишь изменения но и на весь проект в целом, если видишь что где-то сделано не очень хорошо - исправляй. Так работает и в промышленной разработке (за исключением случаев, когда код написан настолько плохо, что трогать его страшно)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@raccoon6996