-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 make ci/cd more declarative #201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aufi
reviewed
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, let's discuss it on the call.
djzager
force-pushed
the
ci-improvements
branch
2 times, most recently
from
August 19, 2024 22:13
f7811cc
to
acf9c6c
Compare
jmontleon
reviewed
Aug 20, 2024
jmontleon
reviewed
Aug 20, 2024
djzager
force-pushed
the
ci-improvements
branch
from
August 20, 2024 14:57
acf9c6c
to
af450b7
Compare
Referencing #201 but don't want to close on merge. |
djzager
force-pushed
the
ci-improvements
branch
from
August 20, 2024 20:20
af450b7
to
42ce54b
Compare
Signed-off-by: David Zager <[email protected]>
djzager
force-pushed
the
ci-improvements
branch
from
August 20, 2024 20:36
42ce54b
to
b5e9e29
Compare
aufi
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for writing this enhancement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.