✨ Analysis automation base work #66
Conversation
…tests Signed-off-by: Alejandro Brugarolas <[email protected]>
abrugaro
force-pushed
the
feat-analysis
branch
from
66c4fb9 to
fdc0ef5
Compare
e2e/pages/vscode.pages.ts
Outdated
| */ | ||
| public async getServerStatusIframe(): Promise<FrameLocator | null> { | ||
| public async getLeftIframe(): Promise<FrameLocator | null> { |
There was a problem hiding this comment.
This method was no longer used and was replaced by getServerStatusIframe() method .
https://github.com/konveyor/kai-ci/blob/main/e2e/pages/vscode.pages.ts#L133
There was a problem hiding this comment.
Solved in 8b9dc7a.
e2e/tests/vscode.test.ts
Outdated
| // } | ||
| await window.waitForTimeout(5000); | ||
| await vscodeApp.openSetUpKonveyor(); | ||
| await window.waitForTimeout(5000); |
There was a problem hiding this comment.
These waits are also replaced by waitforselector.
You need to rebase off main branch ?
https://github.com/konveyor/kai-ci/blob/main/e2e/tests/vscode.test.ts#L36
There was a problem hiding this comment.
Solved in 8b9dc7a.
I kept some of the changes that were on main but replaced some others
Signed-off-by: Alejandro Brugarolas <[email protected]>
Signed-off-by: Alejandro Brugarolas <[email protected]>
| await window.waitForSelector('span:text("Start Analyzer")'); | ||
| await window.locator('span:has-text("Start Analyzer")').click(); | ||
| const konveyorView = await window.getByText('Konveyor Analysis View'); |
There was a problem hiding this comment.
We don't want to assert that the konveyor analysis view opened and server is running ?
There was a problem hiding this comment.
Right now that's affected by konveyor/editor-extensions#389, we can add that assertion once it is fixed, wdyt ?
Part of #51.
This PR includes: