Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Questionnaire delete: On a second delete, the name of the previously deleted item is still showing #1478

Closed
1 task done
sjd78 opened this issue Oct 16, 2023 · 0 comments · Fixed by #1479
Closed
1 task done

Questionnaire delete: On a second delete, the name of the previously deleted item is still showing #1478

sjd78 opened this issue Oct 16, 2023 · 0 comments · Fixed by #1479
Assignees
@sjd78
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sjd78
Copy link
Member

sjd78 commented Oct 16, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

main

Priority

Major

Current Behavior

  1. Create at least 2 questionnaires to be deleted.

  2. Delete the first questionnaire, typing in its name.

  3. Delete the second questionnaire -- the previously deleted name is retained! The action isn't blocked as you can change the name to the item being deleted and it will work.

Expected Behavior

On the second delete, the name box should be empty.

How Reproducible

Always (Default)
@sjd78 sjd78 added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 16, 2023
@sjd78 sjd78 self-assigned this Oct 16, 2023
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Oct 16, 2023
@sjd78
🐛 ConfirmDeleteDialog: always clear name input value on action
d998da0 
ConfirmDeleteDialog requires the user to enter the item's name
before the delete button is enabled.  The user entered text was
being cleared on Cancel and Close, but not on Confirm.  Action
handlers now clear the user entered text on ALL actions.

Resolves: konveyor#1478

Signed-off-by: Scott J Dickerson <[email protected]>
@sjd78 sjd78 mentioned this issue Oct 16, 2023
Merged
@sjd78 sjd78 moved this to In Progress in Konveyor UI Oct 16, 2023
ibolton336 added a commit that referenced this issue Oct 17, 2023
@sjd78 @ibolton336
🐛 ConfirmDeleteDialog: always clear name input value on action (#1479)
12d8166 
`ConfirmDeleteDialog` requires the user to enter the item's name before
the delete button is enabled. The user entered text was being cleared on
Cancel and Close, but not on Confirm. Action handlers now clear the user
entered text on ALL actions.

Resolves: #1478

Signed-off-by: Scott J Dickerson <[email protected]>
Co-authored-by: Ian Bolton <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Konveyor UI Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjd78 sjd78

Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
No open projects
Konveyor UI
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 ConfirmDeleteDialog: always clear name input value on action sjd78/tackle2-ui
1 participant
@sjd78