🐛 ConfirmDeleteDialog: always clear name input value on action #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConfirmDeleteDialog requires the user to enter the item's name before the delete button is enabled. The user entered text was being cleared on Cancel and Close, but not on Confirm. Action handlers now clear the user entered text on ALL actions. Resolves: konveyor#1478 Signed-off-by: Scott J Dickerson <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1479 +/- ##
=======================================
Coverage 40.82% 40.82%
=======================================
Files 139 139
Lines 4458 4458
Branches 1018 1018
=======================================
Hits 1820 1820
Misses 2626 2626
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ibolton336
approved these changes
Oct 16, 2023
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfirmDeleteDialogrequires the user to enter the item's name before the delete button is enabled. The user entered text was being cleared on Cancel and Close, but not on Confirm. Action handlers now clear the user entered text on ALL actions.Resolves: #1478