Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Validation error messages #2150

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aviya-gidan
Copy link

Update validation error messages to ensure all use localization (t())
issue:#213

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 41.99%. Comparing base (b654645) to head (b68214f).
Report is 246 commits behind head on main.

Files with missing lines Patch % Lines
...s/components/application-form/application-form.tsx 25.00% 6 Missing ⚠️
...c/app/pages/applications/analysis-wizard/schema.ts 64.28% 5 Missing ⚠️
...ntities/components/identity-form/identity-form.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2150      +/-   ##
==========================================
+ Coverage   39.20%   41.99%   +2.79%     
==========================================
  Files         146      175      +29     
  Lines        4857     5634     +777     
  Branches     1164     1392     +228     
==========================================
+ Hits         1904     2366     +462     
- Misses       2939     3252     +313     
- Partials       14       16       +2     
Flag Coverage Δ
client 41.99% <50.00%> (+2.79%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants