Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): added callouts for documentation pages (#DS-2547) #433

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

artembelik
Copy link
Contributor

@artembelik artembelik commented Nov 15, 2024

scrollbar page:
image

validation page:
image

theming page:
image

form field page:
image

markdown page:
image

@artembelik artembelik changed the title chore(docs): added callouts for documentation pages chore(docs): added callouts for documentation pages (#DS-2547) Nov 15, 2024
Copy link

Visit the preview URL for this PR (updated for commit 3276fd0):

https://koobiq-next--prs-433-q8auv1i8.web.app

(expires Wed, 20 Nov 2024 13:38:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@vitalyozza
Copy link
Contributor

@artembelik проверь пожалуйста отступы, они в фигме иные. + ставишь дополнительно внутри текста отступ снизу, что создает лишнее пустое пространство
image

@vitalyozza
Copy link
Contributor

Если параграф вставляешь в callout, то убирай у последнего параграфа отступ снизу.

Copy link
Contributor

@NikGurev NikGurev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит топ!
Есть пару предложений, отпишись что думаешь.

font-weight: var(--kbq-md-typography-md-body-font-weight);
line-height: var(--kbq-md-typography-md-body-line-height);
letter-spacing: var(--kbq-md-typography-md-body-letter-spacing);
border-radius: var(--kbq-size-s) var(--kbq-size-s) 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

команда UX завела глобальный токен border-radius, у него такое же значение, но он больше подходит для описания бордер радиуса

Suggested change
border-radius: var(--kbq-size-s) var(--kbq-size-s) 0;
border-radius: var(--kbq-size-border-radius) var(--kbq-size-border-radius) 0;

Comment on lines +53 to +56
font-size: var(--kbq-md-typography-md-body-font-size);
font-weight: var(--kbq-md-typography-md-body-font-weight);
line-height: var(--kbq-md-typography-md-body-line-height);
letter-spacing: var(--kbq-md-typography-md-body-letter-spacing);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если стили типографики раздела полностью совпадают с определенным шрифтом, то можно его напрямую использовать

Suggested change
font-size: var(--kbq-md-typography-md-body-font-size);
font-weight: var(--kbq-md-typography-md-body-font-weight);
line-height: var(--kbq-md-typography-md-body-line-height);
letter-spacing: var(--kbq-md-typography-md-body-letter-spacing);
@extend .md-body;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants