This repository has been archived by the owner on Apr 17, 2024. It is now read-only.
docs: add isntructions for installing KDCC on demo #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
52caafd
|
| Status: | ⚡️ Build in progress... |
zalsader
force-pushed
the
feature/gen-249
branch
from
206bf43
to
9018727
Compare
ideepika
approved these changes
Oct 5, 2023
galexrt
reviewed
Oct 5, 2023
| # The ACME server URL | ||
| server: https://acme-staging-v02.api.letsencrypt.org/directory | ||
| # Email address used for ACME registration | ||
| email: [email protected] |
There was a problem hiding this comment.
Please make it the admin email instead of your company email:
Suggested change
| email: zuhair@koor.tech | |
| email: admin@koor.tech |
galexrt
reviewed
Oct 5, 2023
| spec: | ||
| acme: | ||
| # The ACME server URL | ||
| server: https://acme-staging-v02.api.letsencrypt.org/directory |
There was a problem hiding this comment.
~~You are using the Letsencrypt Staging Server. These certificates aren't "valid" without manually installing the staging CA (which you shouldn't).
Please switch to the "live"/production Letsencrpyt servers to make sure we have valid certificates for everyone.~~
Edit: I am not sure why you create the staging issuer if the prod one is used anyway here.
There was a problem hiding this comment.
It was used for testing the system at the beginning since the prod is rate-limited. I removed it form the docs now.
Signed-off-by: Zuhair AlSader <[email protected]>
zalsader
force-pushed
the
feature/gen-249
branch
from
9018727
to
52caafd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.