Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video options #164

Merged
merged 3 commits into from
Oct 3, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add description
  • Loading branch information
kopiro committed Oct 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit eac419f50abb67b48b61295d3b8a8e450fa93554
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -8,6 +8,8 @@ Make your TP-Link TAPO security camera compatible with Homekit through Homebridg

The plugin exposes the camera RTSP video feed, and toggle accessories to configure your automations.

If your video feed is not working, try to check if any of the parameters at the video config can be tuned. You can use [https://sunoo.github.io/homebridge-camera-ffmpeg/configs](https://sunoo.github.io/homebridge-camera-ffmpeg/configs) to check if someone has already found the right values for your camera.

### Toggle accessories

- _"Eyes"_ controls the privacy mode; when it's on it means that the camera is able to see
9 changes: 5 additions & 4 deletions config.schema.json
Original file line number Diff line number Diff line change
@@ -2,8 +2,8 @@
"pluginAlias": "tapo-camera",
"pluginType": "platform",
"singular": true,
"headerDisplay": "Homebridge plugin for TP-Link TAPO security cameras",
"footerDisplay": null,
"headerDisplay": "Homebridge plugin for TP-Link TAPO security cameras.",
"footerDisplay": "If your video feed is not working, try to check if any of the parameters at the video config can be tuned. You can use https://sunoo.github.io/homebridge-camera-ffmpeg/configs to check if someone has already found the right values for your camera.",
"form": null,
"display": null,
"schema": {
@@ -100,7 +100,7 @@
"lowQuality": {
"title": "Low Quality",
"type": "boolean",
"description": "Video stream will be requested in low-quality (640x480) instead of HQ (1920x1080)"
"description": "Video stream will be requested in low-quality instead of high-quality"
},
"eyesToggleAccessoryName": {
"title": "Eyes (privacy mode) toggle Name",
@@ -132,6 +132,7 @@
"description": "Name of the LED toggle",
"placeholder": "LED"
},

"videoMaxWidth": {
"title": "Video Max Width",
"type": "integer",
@@ -165,7 +166,7 @@
"videoForceMax": {
"title": "Force Max Video",
"type": "boolean",
"description": "Force the video stream to use the maximum values"
"description": "Force the video stream to use the maximum values, instead of the one provided by the Homekit request. Most likely you don't want this"
}
}
}
3 changes: 3 additions & 0 deletions src/cameraAccessory.ts
Original file line number Diff line number Diff line change
@@ -183,6 +183,7 @@ export class CameraAccessory {
forceMax: this.config.videoForceMax,
...(this.config.videoConfig || {}),
};

return config;
}

@@ -204,6 +205,8 @@ export class CameraAccessory {
);

this.accessory.configureController(delegate.controller);

this.log.debug("Camera streaming setup done");
} catch (err) {
this.log.error("Error setting up camera streaming:", err);
}