Skip to content

Commit

Permalink
Fix enablement of Aux dialog's "Generate" button (JabRef#10775)
Browse files Browse the repository at this point in the history
* Fix enablement of Aux dialog's "Generate" button

* Add link to PR
  • Loading branch information
koppor authored Jan 13, 2024
1 parent bd27d5d commit 46ece6f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
- The index directories for full text search have now more readable names to increase debugging possibilities using Apache Lucense's Lurk. [#10193](https://github.com/JabRef/jabref/issues/10193)
- The fulltext search also indexes files ending with .pdf (but do not having an explicit file type set). [#10193](https://github.com/JabRef/jabref/issues/10193)
- We changed the order of the lists in the "Citation relations" tab. `Cites` are now on the left and `Cited by` on the right [#10572](https://github.com/JabRef/jabref/pull/10752)
- Sub libraries based on `aux` file can now also be generated if some citeations are not found library. [#10775](https://github.com/JabRef/jabref/pull/10775)

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/gui/auximport/FromAuxDialog.java
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public FromAuxDialog(LibraryTabContainer tabContainer) {
.setAsDialogPane(this);

Button generateButton = (Button) this.getDialogPane().lookupButton(generateButtonType);
generateButton.disableProperty().bind(viewModel.parseFailedProperty().or(viewModel.notFoundList().emptyProperty().not()));
generateButton.disableProperty().bind(viewModel.parseFailedProperty());
generateButton.defaultButtonProperty().bind(generateButton.disableProperty().not());
setResultConverter(button -> {
if (button == generateButtonType) {
Expand Down

0 comments on commit 46ece6f

Please sign in to comment.