Replace throw new RuntimeException by LOGGER / other throws (JabRef#1…

…0982)
koppor · Mar 5, 2024 · 967b651 · 967b651
1 parent 8374693
commit 967b651
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 11 deletions.
diff --git a/...main/java/org/jabref/gui/entryeditor/citationrelationtab/BibEntryRelationsRepository.java b/...main/java/org/jabref/gui/entryeditor/citationrelationtab/BibEntryRelationsRepository.java
@@ -6,7 +6,12 @@
 import org.jabref.logic.importer.FetcherException;
 import org.jabref.model.entry.BibEntry;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 public class BibEntryRelationsRepository {
+    private static final Logger LOGGER = LoggerFactory.getLogger(BibEntryRelationsRepository.class);
+
     private final SemanticScholarFetcher fetcher;
     private final BibEntryRelationsCache cache;
 
@@ -25,7 +30,13 @@ public List<BibEntry> getCitations(BibEntry entry) {
 
     public List<BibEntry> getReferences(BibEntry entry) {
         if (needToRefreshReferences(entry)) {
-            List<BibEntry> references = fetcher.searchCiting(entry);
+            List<BibEntry> references;
+            try {
+                references = fetcher.searchCiting(entry);
+            } catch (FetcherException e) {
+                LOGGER.error("Error while fetching references", e);
+                references = List.of();
+            }
             cache.cacheOrMergeReferences(entry, references);
         }
 
@@ -37,7 +48,7 @@ public void forceRefreshCitations(BibEntry entry) {
             List<BibEntry> citations = fetcher.searchCitedBy(entry);
             cache.cacheOrMergeCitations(entry, citations);
         } catch (FetcherException e) {
-            throw new RuntimeException(e);
+            LOGGER.error("Error while fetching citations", e);
         }
     }
 
@@ -50,7 +61,13 @@ public boolean needToRefreshReferences(BibEntry entry) {
     }
 
     public void forceRefreshReferences(BibEntry entry) {
-        List<BibEntry> references = fetcher.searchCiting(entry);
+        List<BibEntry> references;
+        try {
+            references = fetcher.searchCiting(entry);
+        } catch (FetcherException e) {
+            LOGGER.error("Error while fetching references", e);
+            references = List.of();
+        }
         cache.cacheOrMergeReferences(entry, references);
     }
 }
diff --git a/...rg/jabref/gui/entryeditor/citationrelationtab/semanticscholar/SemanticScholarFetcher.java b/...rg/jabref/gui/entryeditor/citationrelationtab/semanticscholar/SemanticScholarFetcher.java
@@ -3,7 +3,6 @@
 import java.io.IOException;
 import java.net.URI;
 import java.net.URL;
-import java.util.ArrayList;
 import java.util.List;
 
 import org.jabref.logic.importer.FetcherException;
@@ -50,15 +49,14 @@ public List<BibEntry> searchCitedBy(BibEntry entry) throws FetcherException {
                                         .stream().filter(citationDataItem -> citationDataItem.getCitingPaper() != null)
                                         .map(citationDataItem -> citationDataItem.getCitingPaper().toBibEntry()).toList();
             } catch (IOException e) {
-                throw new RuntimeException(e);
+                throw new FetcherException("Could not fetch", e);
             }
         }
-
-        return new ArrayList<>();
+        return List.of();
     }
 
     @Override
-    public List<BibEntry> searchCiting(BibEntry entry) {
+    public List<BibEntry> searchCiting(BibEntry entry) throws FetcherException {
         if (entry.getDOI().isPresent()) {
             StringBuilder urlBuilder = new StringBuilder(SEMANTIC_SCHOLAR_API)
                     .append("paper/")
@@ -82,11 +80,10 @@ public List<BibEntry> searchCiting(BibEntry entry) {
                                          .filter(citationDataItem -> citationDataItem.getCitedPaper() != null)
                                          .map(referenceDataItem -> referenceDataItem.getCitedPaper().toBibEntry()).toList();
             } catch (IOException e) {
-                throw new RuntimeException(e);
+                throw new FetcherException("Could not fetch", e);
             }
         }
-
-        return new ArrayList<>();
+        return List.of();
     }
 
     @Override