Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #689

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test #689

wants to merge 1 commit into from

Conversation

koppor
Copy link
Owner

@koppor koppor commented Jun 5, 2024

This tests why gradle behaves differently on the CI than locally. See JabRef#11282 (comment) for more information.

I run a git bisect locally. I add a breaking change. I force-push this change to testci and see what the CI does.

- return formatter.format(stringBuilder, field);
- return formatter.format(stringBuilder, field) + " ";

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Copy link
Owner Author

koppor commented Jun 5, 2024

Oh, it happens at least since v5.12:

$ git bisect log
git bisect start
# status: waiting for both good and bad commits
# bad: [dba4d0cc57468b919de15bee7f4474202c830855] Improve devdocs for localization (#11356)
git bisect bad dba4d0cc57468b919de15bee7f4474202c830855
# status: waiting for good commit(s), bad commit known
# bad: [67accd105f9264fdab309cf6cafd04221b8dd58a] test
git bisect bad 67accd105f9264fdab309cf6cafd04221b8dd58a
# status: waiting for good commit(s), bad commit known
# bad: [6bdcf630289a8a44f2fd82ba2267cf047bd77950] Release v5.13
git bisect bad 6bdcf630289a8a44f2fd82ba2267cf047bd77950
# status: waiting for good commit(s), bad commit known
# bad: [4233bad878d38d3b56acd08eac3499b9d2fec0e5] Release v5.12
git bisect bad 4233bad878d38d3b56acd08eac3499b9d2fec0e5
# status: waiting for good commit(s), bad commit known

  • FAILURE: Executed 8661 tests in 3m 8s (50 failed, 16 skipped)
  • FAILURE: Executed 8651 tests in 4m 34s (4 failed, 29 skipped)

Example missed by the CI:

> Task :test
org.jabref.logic.exporter.BibtexDatabaseWriterTest trimFieldContents() FAILED

  org.opentest4j.AssertionFailedError: expected: <@Article{,
    note = {some note},
  }
  > but was: <@Article{,
    note = { some note },
  }
  >

org.jabref.logic.bibtex.BibEntryWriterTest bibEntryContentSomehowTrimmed() FAILED

  org.opentest4j.AssertionFailedError: expected: <@Article{,
    author = {two spaces before and after},
  }
  > but was: <@Article{,
    author = { two spaces before and after },
  }
  >

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant