-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support kord-voice on Kotlin/JS and Windows #69
Comments
Kotlin/kotlinx.coroutines#462 got closed, so we actually have multithreaded coroutines on native now |
WS support is there now as ktorio/ktor@e7c8c03 got merged however there is no |
Regarding the stable memory model for native, the new memory manager is now stable and used by default (https://kotlinlang.org/docs/native-memory-manager.html). |
It's technically in Beta but so are Kotlin/Native and Kotlin Multiplatform: https://kotlinlang.org/docs/components-stability.html#current-stability-of-kotlin-components |
Currently, a WIP MPP version of kord is on the |
This commit attempts to provide Kotlin/JS support for Kord (see #69) Breaking Changes: * The following member functions were replaced by extension functions. Importing the extension functions should fix this breaking change. * dev.kord.common.Locale.asJavaLocale -> import dev.kord.common.asJavaLocale * dev.kord.core.cache.KordCacheBuilder.lruCache -> import dev.kord.core.cache.lruCache * dev.kord.rest.builder.message.create.MessageCreateBuilder.addFile -> import dev.kord.rest.builder.message.create.addFile * dev.kord.rest.builder.message.modify.MessageModifyBuilder.addFile -> import dev.kord.rest.builder.message.modify.addFile * dev.kord.rest.request.RequestBuilder.file -> import dev.kord.rest.request.file * The type of the following declarations was changed from java.util.Locale to dev.kord.common.Locale: * dev.kord.core.entity.Guild.preferredLocale * dev.kord.rest.builder.guild.GuildModifyBuilder.preferredLocale * All annotations in dev.kord.common.annotation and the dev.kord.gateway.PrivilegedIntent annotation now have BINARY instead of RUNTIME retention. This means they are no longer visible for reflection. * All maven consumers must append '-jvm' to their artifact IDs for kord-common, kord-rest, kord-gateway and kord-core. * The core-voice capability has been removed, please use the kord-core-voice artifact instead. --------- Co-authored-by: Lukellmann <[email protected]>
The use of value classes for the Reset class has already caused issues implementing #855. However, it was isolated to native platforms. Unfortunately, this behavior will become a compiler error soon, so we need to change it. This can be achieved by simply using the backing Instant instead of Reset with AtomicRef. Related Issues: #855 #69 Kotlin/kotlinx-atomicfu#291 https://youtrack.jetbrains.com/issue/KT-61584 Co-authored-by: lukellmann <[email protected]>
Is it possible to add Kotlin/Wasm compatibility ? |
We don't really see the point behind running Kord in the browser, since it only supports the bot api and not the OAuth API, so we don't have a checklist for WASM suppor |
targetting wasmWasi might be a thing to do in the future though |
and wasm can also be run in node iirc, so even adding wasmJs might be possible |
Ktor 3.1.0 will have JS support for voice: https://youtrack.jetbrains.com/issue/KTOR-6004/Support-NodeJs-target-for-ktor-network |
Maybe @lost-illusi0n, @viztea and @lukellmann can chime in for items required for DAVE |
Since 0.9.0 Kotlin/JS is officially supported, see #775 and 0.9.0 for more information, for progress on Kotlin/Native check #855
kord-voice
ktor-network for js(Workaround using nodejs dgram module by @viztea)The text was updated successfully, but these errors were encountered: