Change "dev.kord.rest.version" to be retrieved via getProperty, not getenv
#575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure whether we should change this now, as I plan to bring a replacement in the form of more publicly available configuration options (this is internal anyways). |
HopeBaron
added
the
on hold
|
Considering #69 I don't think it's a good idea to add more dependencies to the JVM stdlib because getProperty is not available on other platforms. I think we should wait for @lukellmann's replacement |
|
Superseded by #601 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev.kord.rest.versionlooks and sounds like a Java System Property... but it is retrieved viagetenv.However environment variables use
UPPERCASED_VARIABLESas the convention, so I don't think this was meant to be retrieved viagetenv.