Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple files support #247

Merged
merged 6 commits into from
Apr 18, 2021
Merged

Multiple files support #247

merged 6 commits into from
Apr 18, 2021

Conversation

HopeBaron
Copy link
Member

This added support for multiple file uploads for requests mentioned in #226.
However, the webhook edit endpoint is still unimplemented. (#217)

@HopeBaron HopeBaron marked this pull request as draft April 5, 2021 19:46
@HopeBaron HopeBaron marked this pull request as ready for review April 17, 2021 04:03
Comment on lines 102 to 103
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
)
)

suspend fun setFile(path: Path) = withContext(Dispatchers.IO) {
setFile(path.fileName.toString(), Files.newInputStream(path))
suspend fun addFile(path: Path) = withContext(Dispatchers.IO) {
addFile(path.fileName.toString(), Files.newInputStream(path))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

@HopeBaron HopeBaron merged commit b82cb7d into 0.7.x Apr 18, 2021
@HopeBaron HopeBaron deleted the multiple-files-support branch April 18, 2021 15:19
@HopeBaron HopeBaron mentioned this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants