Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Snowflakes to be
value class
to reduce their memory footprint.I know that this PR probably won't be merged because it is a huge binary change, so it would break everything. Anyhow, this PR is here so other users can implement this change in their own Kord fork, if they need it.
Related to #711
Sadly the constructor can't have
value.coerceIn(validValues)
, and we can't use ainterface
to "hide" the value class behind aSnowflakeImpl
because, if you use interfaces, the class will be boxed. The failing tests are related to the missingcoerceIn
call.