Feature/ht4 #62
Open
Feature/ht4 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koretskiyav
reviewed
Oct 26, 2021
| @@ -56,8 +57,8 @@ Product.propTypes = { | |||
| }; | |||
|
|
|||
| const mapStateToProps = (state, props) => ({ | |||
| amount: state.order[props.id] || 0, | |||
| product: state.products[props.id], | |||
| amount: orderSelector(state)[props.id] || 0, | |||
There was a problem hiding this comment.
лучше делать селекторы от всех стейта и пропов, вроде orderSelector(state, props), расскажу при разборе домашки почему
koretskiyav
reviewed
Oct 26, 2021
| const [activeTab, setActiveTab] = useState('menu'); | ||
|
|
||
| const reviews = useMemo( |
There was a problem hiding this comment.
это вычисление лучше перенести в селекторы
koretskiyav
reviewed
Oct 26, 2021
| const tabs = useMemo( | ||
| () => restaurants.map(({ id, name }) => ({ id, label: name })), | ||
| () => | ||
| Object.values(restaurants).map(({ id, name }) => ({ id, label: name })), |
There was a problem hiding this comment.
это вычисление лучше перенести в селектор
koretskiyav
reviewed
Oct 26, 2021
|
|
||
| return { | ||
| review, | ||
| user: usersSelector(state)[review.userId], |
There was a problem hiding this comment.
это все можно выбрать через один селектор usersSelector(state, props)
koretskiyav
reviewed
Oct 26, 2021
| const user = { id: userId, name }; | ||
| const review = { id: uuidv4(), userId, text, rating }; | ||
|
|
||
| next(addUser(user)); |
There was a problem hiding this comment.
это лучше делать через один екшен, покажу на своей домашке и на разборе расскажу в чем может быть проблема такого подхода
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.