add routes and links to basket item HT6 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koretskiyav
reviewed
Nov 2, 2021
| @@ -10,7 +10,7 @@ export default class App extends PureComponent { | |||
| <div> | |||
| <Header /> | |||
| <Switch> | |||
| <Route path="/" exact component={() => <h2>Home page</h2>} /> | |||
| <Route path="/" exact component={Restaurants} /> | |||
There was a problem hiding this comment.
тут должен быть Redirect, а не Route
koretskiyav
reviewed
Nov 2, 2021
| @@ -22,7 +25,7 @@ export default (state = initialState, action) => | |||
| draft.loading[restId] = false; | |||
| draft.loaded[restId] = true; | |||
| draft.error = null; | |||
| Object.assign(draft.entities, arrToMap(data)); | |||
| Object.assign(draft.entities, arrToMap(dataWithRestId)); | |||
There was a problem hiding this comment.
Из данных, которые у нас лежат в редьюсере ресторанов мы можем однозначно сказать какой продукт из какого ресторана. Теперь эта информация у нас есть в двух местах, тут и в ресторанах. Так делать не стоит.
koretskiyav
reviewed
Nov 2, 2021
| <Switch> | ||
| <Route path="/restaurants/:restId/:activeTab"> | ||
| {({ match }) => { | ||
| switch (match.params.activeTab) { |
There was a problem hiding this comment.
проще сделать несколько Route, покажу на своей домашке
koretskiyav
reviewed
Nov 2, 2021
| key={product.id} | ||
| subtotal={subtotal} | ||
| /> | ||
| <Link to={`/restaurants/${product.restId}`} key={product.id}> |
There was a problem hiding this comment.
тут лучше не весь BasketItem вместе с кнопками оборачивать в Link, а только имя продукта
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.