Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute path for package readme #62

Closed
wants to merge 2 commits into from

Conversation

orhun
Copy link

@orhun orhun commented Dec 22, 2022

While running cargo-deb for git-cliff, I got the following error:

$ cargo-deb  --strip --manifest-path git-cliff/Cargo.toml -v
cargo-deb: unable to read extended description from file: ../README.md
  because: No such file or directory (os error 2)

This is due to git-cliff being a workspace package and pointing out to a readme file in a parent directory:

[package]
readme = "../README.md"

This PR fixes this issue by using an canonicalized absolute path for readme file.

@kornelski
Copy link
Owner

kornelski commented Dec 23, 2022

These paths also break Cargo (it fails to package the readme), so I don't intend to support them. Use a symlink instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants