Skip to content

Commit

Permalink
Merge pull request #7 from KostyaBakay/dev
Browse files Browse the repository at this point in the history
Code refactoring
  • Loading branch information
kostyabakay authored Oct 30, 2018
2 parents 44477a3 + 402e72a commit f4e4d5a
Show file tree
Hide file tree
Showing 40 changed files with 1,161 additions and 1,168 deletions.
47 changes: 43 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,46 @@
# Built application files
*.apk
*.ap_

# Gradle files
.gradle/
build/

# Local configuration file (sdk path, etc)
local.properties

# Intellij
*.iml
.gradle
/local.properties
/.idea
.idea/

# External native build folder generated in Android Studio 2.2 and later
/.externalNativeBuild

# Google Services (e.g. APIs or Firebase)
google-services.json

# Proguard folder generated by Eclipse
proguard/

# Log Files
*.log

# Android Studio Navigation editor temp files
.navigation/

# Android Studio captures folder
captures/

.DS_Store
/build
/captures

# Files for the ART/Dalvik VM
*.dex

# Java class files
*.class

# Generated files
bin/
gen/
out/
25 changes: 18 additions & 7 deletions app/build.gradle
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
apply plugin: 'com.android.application'
apply plugin: 'io.fabric'
apply plugin: 'com.google.firebase.firebase-perf'

android {
compileSdkVersion 27
buildToolsVersion '27.0.3'
compileSdkVersion 28
buildToolsVersion '28.0.3'

defaultConfig {
applicationId "com.kostyabakay.braintraininggame"
minSdkVersion 16
targetSdkVersion 27
versionCode 5
versionName "1.0.4"
targetSdkVersion 28
versionCode 6
versionName "1.1"
}

buildTypes {
Expand All @@ -23,5 +25,14 @@ android {
dependencies {
implementation fileTree(dir: 'libs', include: ['*.jar'])
testImplementation 'junit:junit:4.12'
implementation 'com.android.support:appcompat-v7:27.1.1'
}
implementation ('com.android.support:appcompat-v7:28.0.0') {
exclude group: 'com.android.support', module: 'support-media-compat'
}
implementation 'com.google.firebase:firebase-core:16.0.4'
implementation 'com.google.firebase:firebase-perf:16.2.0'
implementation 'com.crashlytics.sdk.android:crashlytics:2.9.5'
implementation 'com.jakewharton:butterknife:8.8.1'
annotationProcessor 'com.jakewharton:butterknife-compiler:8.8.1'
}

apply plugin: 'com.google.gms.google-services'
2 changes: 1 addition & 1 deletion app/proguard-rules.pro
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
# class:
#-keepclassmembers class fqcn.of.javascript.interface.for.webview {
# public *;
#}
#}
26 changes: 12 additions & 14 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
android:label="@string/app_name"
android:supportsRtl="true"
android:theme="@style/AppTheme">
<activity
android:name=".activity.BaseActivity"
android:screenOrientation="portrait" />
<activity
android:name="com.kostyabakay.braintraininggame.activity.MenuActivity"
android:label="@string/app_name"
Expand All @@ -19,27 +22,22 @@
<activity
android:name="com.kostyabakay.braintraininggame.activity.GameActivity"
android:label="@string/game"
android:parentActivityName=".activity.MenuActivity">
android:screenOrientation="portrait">
</activity>
android:parentActivityName=".activity.MenuActivity"
android:screenOrientation="portrait" />
<activity
android:name="com.kostyabakay.braintraininggame.activity.RulesActivity"
android:label="@string/menu_rules"
android:parentActivityName=".activity.MenuActivity">
android:screenOrientation="portrait">
</activity>
android:parentActivityName=".activity.MenuActivity"
android:screenOrientation="portrait" />
<activity
android:name="com.kostyabakay.braintraininggame.activity.AuthorActivity"
android:label="@string/menu_author"
android:parentActivityName=".activity.MenuActivity">
android:screenOrientation="portrait">
</activity>
android:parentActivityName=".activity.MenuActivity"
android:screenOrientation="portrait" />
<activity
android:name="com.kostyabakay.braintraininggame.activity.SettingsActivity"
android:label="@string/menu_settings"
android:parentActivityName=".activity.MenuActivity">
android:screenOrientation="portrait">
</activity>
android:parentActivityName=".activity.MenuActivity"
android:screenOrientation="portrait" />
</application>

</manifest>
</manifest>
11 changes: 0 additions & 11 deletions app/src/main/java/com/kostyabakay/braintraininggame/AppData.java

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,78 +1,52 @@
package com.kostyabakay.braintraininggame.activity;

import android.content.Context;
import android.content.Intent;
import android.net.Uri;
import android.os.Bundle;
import android.support.v7.app.AppCompatActivity;
import android.view.View;
import android.widget.ImageView;
import android.support.annotation.NonNull;

import com.kostyabakay.braintraininggame.R;
import com.kostyabakay.braintraininggame.common.constant.SocialUrl;

/**
* Created by Kostya on 08.03.2016.
* This class represents Activity with information about author of this application.
*/
public class AuthorActivity extends AppCompatActivity {
private static final String TWITTER_URL = "https://twitter.com/Kostya_Bakay";
private static final String INSTAGRAM_URL = "https://instagram.com/kostya_bakay";
private static final String GITHUB_URL = "https://github.com/kostyabak";
private static final String LINKEDIN_URL = "https://ua.linkedin.com/in/kostyabakay";
import butterknife.ButterKnife;
import butterknife.OnClick;

public class AuthorActivity extends BaseActivity {

public static void start(@NonNull Context context) {
Intent starter = new Intent(context, AuthorActivity.class);
context.startActivity(starter);
}

//region BaseActivity
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_author);
initView();
ButterKnife.bind(this);
}
//endregion

/**
* Initialization view elements on the screen.
*/
private void initView() {
ImageView twitterImageView = (ImageView) findViewById(R.id.twitter_image);
ImageView instagramImageView = (ImageView) findViewById(R.id.instagram_image);
ImageView githubImageView = (ImageView) findViewById(R.id.github_image);
ImageView linkedinImageView = (ImageView) findViewById(R.id.linkedin_image);

twitterImageView.setOnClickListener(new View.OnClickListener() {
public void onClick(View v) {
Intent twitterIntent = new Intent();
twitterIntent.setAction(Intent.ACTION_VIEW);
twitterIntent.addCategory(Intent.CATEGORY_BROWSABLE);
twitterIntent.setData(Uri.parse(TWITTER_URL));
startActivity(twitterIntent);
}
});
//region ButterKnife
@OnClick(R.id.twitter_image)
void onTwitterClick() {
openWebPage(Uri.parse(SocialUrl.TWITTER));
}

instagramImageView.setOnClickListener(new View.OnClickListener() {
public void onClick(View v) {
Intent instagramIntent = new Intent();
instagramIntent.setAction(Intent.ACTION_VIEW);
instagramIntent.addCategory(Intent.CATEGORY_BROWSABLE);
instagramIntent.setData(Uri.parse(INSTAGRAM_URL));
startActivity(instagramIntent);
}
});
@OnClick(R.id.instagram_image)
void onInstagramClick() {
openWebPage(Uri.parse(SocialUrl.INSTAGRAM));
}

githubImageView.setOnClickListener(new View.OnClickListener() {
public void onClick(View v) {
Intent githubIntent = new Intent();
githubIntent.setAction(Intent.ACTION_VIEW);
githubIntent.addCategory(Intent.CATEGORY_BROWSABLE);
githubIntent.setData(Uri.parse(GITHUB_URL));
startActivity(githubIntent);
}
});
@OnClick(R.id.github_image)
void onGitHubClick() {
openWebPage(Uri.parse(SocialUrl.GITHUB));
}

linkedinImageView.setOnClickListener(new View.OnClickListener() {
public void onClick(View v) {
Intent linkedinIntent = new Intent();
linkedinIntent.setAction(Intent.ACTION_VIEW);
linkedinIntent.addCategory(Intent.CATEGORY_BROWSABLE);
linkedinIntent.setData(Uri.parse(LINKEDIN_URL));
startActivity(linkedinIntent);
}
});
@OnClick(R.id.linkedin_image)
void onLinkedInClick() {
openWebPage(Uri.parse(SocialUrl.LINKED_IN));
}
}
//endregion
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package com.kostyabakay.braintraininggame.activity;

import android.app.Fragment;
import android.app.FragmentTransaction;
import android.content.Intent;
import android.net.Uri;
import android.support.annotation.IdRes;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.support.v7.app.AppCompatActivity;

public class BaseActivity extends AppCompatActivity {
public void replaceFragment(@IdRes int containerViewId, @NonNull Fragment fragment) {
FragmentTransaction fragmentTransaction = getFragmentManager().beginTransaction();
fragmentTransaction.replace(containerViewId, fragment);
fragmentTransaction.commit();
}

public void openWebPage(@Nullable Uri webPageUri) {
Intent intent = new Intent();
intent.setAction(Intent.ACTION_VIEW);
intent.addCategory(Intent.CATEGORY_BROWSABLE);
intent.setData(webPageUri);
startActivity(intent);
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
package com.kostyabakay.braintraininggame.activity;

import android.app.FragmentTransaction;
import android.content.Context;
import android.content.Intent;
import android.os.Bundle;
import android.support.v7.app.AppCompatActivity;
import android.support.annotation.NonNull;

import com.kostyabakay.braintraininggame.R;
import com.kostyabakay.braintraininggame.fragment.GameFragment;
Expand All @@ -11,19 +12,19 @@
* Created by Kostya on 04.03.2016.
* This class represents Activity for game.
*/
public class GameActivity extends AppCompatActivity {
public class GameActivity extends BaseActivity {

public static void start(@NonNull Context context) {
Intent starter = new Intent(context, GameActivity.class);
context.startActivity(starter);
}

//region BaseActivity
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_game);
initGameFragment();
}

private void initGameFragment() {
GameFragment gameFragment = new GameFragment();
FragmentTransaction fragmentTransaction = getFragmentManager().beginTransaction();
fragmentTransaction.replace(R.id.activity_game, gameFragment);
fragmentTransaction.commit();
replaceFragment(R.id.activity_game, GameFragment.newInstance());
}
}
//endregion
}
Loading

0 comments on commit f4e4d5a

Please sign in to comment.