Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ToastManager.updateToastsPositions protected #375

Closed
wants to merge 2 commits into from

Conversation

czyzby
Copy link
Collaborator

@czyzby czyzby commented Dec 9, 2022

@czyzby czyzby requested a review from kotcrab December 9, 2022 23:43
@czyzby czyzby added the ui label Dec 9, 2022
@bploeckelman
Copy link
Contributor

@czyzby I was just poking at this to make my own merge request, but you beat me to it. I think the member variables touched in updateToastsPositions() need to be set protected also. Maybe just make all members protected to cover anything an end-user would want to do?

@czyzby
Copy link
Collaborator Author

czyzby commented Dec 10, 2022

@bploeckelman I can close this PR and let you submit another one. Thanks.

(As a side note, this should also speed up the merging process, as we won't have to wait for kotcrab's review, I think.)

@czyzby czyzby closed this Dec 10, 2022
@bploeckelman
Copy link
Contributor

Sounds good, working on it. I'll probably add support for top and bottom centering while I'm at it. I'll update TestToasts to validate those changes too. Thanks!

@czyzby czyzby deleted the feature/toast-manager-api-improvement branch December 10, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants