Merge pull request #272 from koterpillar/derive-raw-executable

feat: derive raw_executable
koterpillar · Oct 30, 2024 · ced95d0 · ced95d0
2 parents c42ad03 + 7bf917e
commit ced95d0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/mybox/package/archive.py b/mybox/package/archive.py
@@ -18,7 +18,6 @@
 
 class ArchivePackage(ManualPackage, ABC):
     raw: bool | str = False
-    raw_executable: bool = False
 
     binary_paths: list[str] = Field(default_factory=list, alias="binary_path")
     binary_paths_val = allow_singular_none("binary_paths")
@@ -54,7 +53,7 @@ async def extract_raw(self, url: str, source: Path, filename: str) -> None:
 
         extractor = await get_single_extractor(url, driver=self.driver)
         await extractor.extract(archive=source, target=target)
-        if self.raw_executable:
+        if filename in self.binaries:
             await self.driver.make_executable(target)
 
     async def find_in_package_directory(

diff --git a/tests/package/test_github.py b/tests/package/test_github.py
@@ -97,7 +97,6 @@ async def constructor_args(self) -> PackageArgs:
             "repo": "com-lihaoyi/Ammonite",
             "regex": r"^2\.13-3\.[0-9]+\.[0-9]+-M[0-9]-bootstrap$",
             "raw": "amm",
-            "raw_executable": True,
             "binary": "amm",
             "skip_release": "3.0.0",
         }
@@ -131,7 +130,6 @@ async def constructor_args(self) -> PackageArgs:
             "repo": "jqlang/jq",
             "binary": "jq",
             "raw": "jq",
-            "raw_executable": True,
         }
 
     async def check_installed_command(self):
@@ -171,7 +169,6 @@ async def constructor_args(self) -> PackageArgs:
             "repo": "argoproj/argo-workflows",
             "binary": "argo",
             "raw": "argo",
-            "raw_executable": True,
         }
 
     async def check_installed_command(self):