forked from android/architecture-components-samples
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardyeats: BasicSample #1
Open
hardyeats
wants to merge
22
commits into
kotlin-korea:master
Choose a base branch
from
hardyeats:hardyeats-BasicSample
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
model/Product 수정
model/Comment 수정
그에 따라 프래그먼트 코드 정리
hardyeats
commented
Aug 20, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분이 엄청 힘들었는데...
AAC Room을 코틀린으로 쓰고자 할 때,
apply plugin: 'kotlin-kapt'
kapt "android.arch.persistence.room:compiler:" + rootProject.archRoomVersion
이걸 추가해 줘야 하는데, 이렇게 되면 기존의 데이터바인딩 어노테이션 프로세서와 충돌을 일으키나 봐요.
그러면
kapt 'com.android.databinding:compiler:3.0.0-beta2'
이걸 추가해줘서 호환성을 맞춰야 하는 것 같고,
그에 따라 데이터바인딩을 쓴 클래스들은 코틀린으로 변환을 해줘야 하는 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.