Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) cleanup and factorize Switch component #98

Merged
merged 1 commit into from
Nov 5, 2024
Merged

(chore) cleanup and factorize Switch component #98

merged 1 commit into from
Nov 5, 2024

Conversation

kounkou
Copy link
Owner

@kounkou kounkou commented Nov 5, 2024

Description

This PR contains the factorization of the Switch component. Usage of the Switch now depends on the following properties, and signals :

SwitchDelegate {
    id: root

    property alias switchText: root.text
    property alias switchChecked: root.checked
    property alias switchEnabled: root.enabled

    signal checkedChangedExternally(bool checked)

    ...
}

Tests

  • Tested that the code still works as usual
  • Tested that the Switch still behaves as usual

@kounkou kounkou self-assigned this Nov 5, 2024
@kounkou kounkou merged commit 48aca46 into main Nov 5, 2024
3 checks passed
@kounkou kounkou deleted the clean-up branch November 5, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant