rename logback-classic to logback-core #51
Conversation
WalkthroughThe changes update configuration and test files to transition from using Logback Classic to Logback Core. The adapter mappings in YAML files have been modified to update the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (7)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
lvjing2
force-pushed
the
youji-dev
branch
2 times, most recently
from
4e4affb to
a1e84e9
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's limits when posting large numbers of comments. If you are seeing this consistently, please check "Code review limits" under "Moderation" settings.
Actionable comments posted: 1
🧹 Nitpick comments (5)
koupleless-adapter-logback-core-1.1.6/src/test/java/com/alipay/sofa/koupleless/base/build/plugin/MatcherTest.java (1)
39-48: Update test documentation to reflect logback-core.The test documentation still references
logback-classicandkoupleless-adapter-logback-classicwhile the implementation has been updated to use core variants.* test for adaptor: koupleless-adapter-logback * pattern: * matcher: * groupId: ch.qos.logback -* artifactId: logback-classic +* artifactId: logback-core * versionRange: "(,1.4.12)" * adapter: -* artifactId: koupleless-adapter-logback-classic-1.1.6 +* artifactId: koupleless-adapter-logback-core-1.1.6 * groupId: com.alipay.sofa.kouplelesskoupleless-adapter-logback-core-1.4.12/src/test/java/com/alipay/sofa/koupleless/base/build/plugin/MatcherTest.java (1)
39-48: Update test documentation to reflect logback-core.The test documentation still references
logback-classicandkoupleless-adapter-logback-classicwhile the implementation has been updated to use core variants.* test for adaptor: koupleless-adapter-logback * pattern: * matcher: * groupId: ch.qos.logback -* artifactId: logback-classic +* artifactId: logback-core * versionRange: "[1.4.12,)" * adapter: -* artifactId: koupleless-adapter-logback-classic-1.4.12 +* artifactId: koupleless-adapter-logback-core-1.4.12 * groupId: com.alipay.sofa.kouplelesskoupleless-adapter-logback-core-1.1.6/pom.xml (1)
13-13: ArtifactId Renaming and Consistency Check:
The artifactId has been updated to"6"as part of shifting from Logback Classic to Logback Core. This numeric identifier is unconventional and might not be self-descriptive. Please ensure this naming change is intentional, documented, and that all downstream processes or references are updated accordingly.koupleless-adapter-logback-core-1.4.12/pom.xml (1)
13-13: ArtifactId Update for Logback Core Module:
Here the artifactId is now set to"12". As with the previous module, using a numeric identifier can be non-intuitive. Please confirm that this naming convention is part of the overall design and that proper documentation or mapping exists for these numbers across versions.koupleless-adapter-spring-boot-logback-2.7.14/pom.xml (1)
25-26: Spring Boot Adapter Dependency Update:
The dependency artifactId in this Spring Boot module is now"6", which aligns it with the new Logback Core approach. Please ensure that this change integrates smoothly with the configured Spring Boot version and that it does not conflict with any other logging dependencies.
🛑 Comments failed to post (1)
pom.xml (1)
110-111: 🛠️ Refactor suggestion
Module Replacement Update:
The modules section now replaces the old Logback Classic modules withkoupleless-adapter-logback-core-1.4.12andkoupleless-adapter-logback-core-1.1.6. Confirm that there are no residual references to the classic modules elsewhere and that these new modules integrate correctly in the build setup.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage 4.87% 4.87%
Complexity 2 2
=======================================
Files 6 6
Lines 41 41
Branches 4 4
=======================================
Hits 2 2
Misses 39 39 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
koupleless-adapter-spring-boot-logback-2.7.14/pom.xml (1)
24-29: Dependency Update VerificationThe dependency for the adapter has been correctly updated to use the new artifact ID "koupleless-adapter-logback-core-1.1.6" as required by the PR objective. Please verify that this change is consistently applied across the codebase and that any components relying on the previous adapter are updated accordingly.
Also, note that the dependency on Logback from the group "ch.qos.logback" (lines 38–44) still specifies "logback-classic". If the intent is to fully transition to Logback Core, you may need to update or document the rationale for retaining "logback-classic" here.
koupleless-adapter-logback/pom.xml (1)
29-33: Verify Logback Library Dependency
Although the PR title indicates a transition from Logback Classic to Logback Core, the dependency onch.qos.logback:logback-classicremains unchanged here. Please confirm whether this dependency should also be updated tologback-coreto fully align with the change. If an update is needed, consider applying the following diff:- <artifactId>logback-classic</artifactId> + <artifactId>logback-core</artifactId>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
koupleless-adapter-logback-core-1.1.6/pom.xml(2 hunks)koupleless-adapter-logback-core-1.1.6/src/test/java/com/alipay/sofa/koupleless/base/build/plugin/MatcherTest.java(1 hunks)koupleless-adapter-logback-core-1.4.12/pom.xml(2 hunks)koupleless-adapter-logback-core-1.4.12/src/test/java/com/alipay/sofa/koupleless/base/build/plugin/MatcherTest.java(1 hunks)koupleless-adapter-logback/pom.xml(1 hunks)koupleless-adapter-spring-boot-logback-2.7.14/pom.xml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
- koupleless-adapter-logback-core-1.1.6/src/test/java/com/alipay/sofa/koupleless/base/build/plugin/MatcherTest.java
- koupleless-adapter-logback-core-1.4.12/pom.xml
- koupleless-adapter-logback-core-1.4.12/src/test/java/com/alipay/sofa/koupleless/base/build/plugin/MatcherTest.java
- koupleless-adapter-logback-core-1.1.6/pom.xml
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: unit-test-for-springboot3-samples
- GitHub Check: unit-test-for-springboot-samples
- GitHub Check: unit-test-for-sofaboot-samples
- GitHub Check: unit-test-for-dubbo-samples
- GitHub Check: Analyze (java-kotlin)
- GitHub Check: unit-test-for-dubbo32-samples
- GitHub Check: unit-test-for-multi-version-jdk
🔇 Additional comments (1)
koupleless-adapter-logback/pom.xml (1)
22-27: Consistent Renaming of Adapter Artifact
The updated artifactId now reflects the new naming convention (koupleless-adapter-logback-core-1.1.6), which aligns with the PR objective. Please ensure that all references (such as in adapter-mapping files and documentation) are updated consistently across the project.
Summary by CodeRabbit