Skip to content

Update vscode dev dependency and fix build errors #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update vscode dev dependency and fix build errors #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"@types/mocha": "5.2.7",
"typescript": "3.5.3",
"mocha": "6.2.0",
"vscode": "1.1.36",
"vscode": "1.1.37",
"vscode-debugadapter-testsupport": "1.37.0",
"tslint": "5.18.0",
"vsce": "1.66.0"
Expand Down
2 changes: 1 addition & 1 deletion src/quickjsDebug.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ export class QuickJSDebugSession extends SourcemapSession {

protected async threadsRequest(response: DebugProtocol.ThreadsResponse): Promise<void> {
if (this._threads.size === 0) {
await new Promise((resolve, reject) => {
await new Promise<void>((resolve, reject) => {
this.once('quickjs-thread', () => {
resolve();
});
Expand Down
5 changes: 2 additions & 3 deletions src/sourcemapSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ export abstract class SourcemapSession extends LoggingDebugSession {
// keep track of the sourcemaps and the location of the file.map used to load it
private _sourceMaps = new Map<BasicSourceMapConsumer, string>();

abstract async logTrace(message: string);
abstract async getArguments(): Promise<SourcemapArguments>;
abstract logTrace(message: string);
abstract getArguments(): Promise<SourcemapArguments>;

async loadSourceMaps() {
const commonArgs = await this.getArguments();
Expand Down Expand Up @@ -111,7 +111,6 @@ export abstract class SourcemapSession extends LoggingDebugSession {
this.logTrace(`translateFileLocationToRemote: ${JSON.stringify(sourceLocation)} to: ${JSON.stringify(actualSourceLocation)}`);
// convert the local absolute path into a sourcemap relative path.
actualSourceLocation.source = path.relative(path.dirname(sourcemap), sourceLocation.source);
delete actualSourceLocation.column;
// let unmappedPosition: NullablePosition = sm.generatedPositionFor(actualSourceLocation);
let unmappedPositions = sm.allGeneratedPositionsFor(actualSourceLocation);
if (!unmappedPositions || !unmappedPositions.length)
Expand Down