Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing --help for CLI options #176

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bczhc
Copy link

@bczhc bczhc commented Nov 17, 2023

Some subcommands are missing --help options. This PR adds them.

The old behavior:

~ ❯ bcachefs device online --help                                                                                     ✘ INT 16:51:31
bcachefs: invalid option -- '-'
bcachefs device online - readd a device to a running filesystem
Usage: bcachefs device online [OPTION]... device

Options:
  -h, --help                  Display this help and exit

Report bugs to <[email protected]>
~ ❯ bcachefs device offline --help                                                                                          16:51:36
bcachefs: unrecognized option '--help'
Please supply a device

@koverstreet
Copy link
Owner

Could you squash these?

- fix typo
- make device online/offline `--help` option consistent

   Old `device online` command
   only recognize `-h` but not the
   long option `--help`; we should make it
   consistent with the `device offline` command

Signed-off-by: Zhai Can <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants