-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
2 changed files
with
107 additions
and
263 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
a70e028
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably don't understand how this works, but the re.sub() on line 55 seems wrong. It looks like it takes the entire :ffdoc:: expression out of the source that translators see, therefore dropping the :ffdoc: from the translated output. Shouldn't it leave the raw :ffdoc:
func
expression in the text to be translated?The re.sub() on line 61 uses the function ffdoc() to replace the first match group. The re.sub() on line 55 replaces the entire pattern with a space. It seems to me that it should replace the pattern with r':ffdoc:
\1
'.a70e028
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a70e028
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.